[webkit-reviews] review denied: [Bug 56263] XML Viewer: extensions can't render original XML : [Attachment 85699] Patch with fixes

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 56263: XML Viewer: extensions can't render original XML
https://bugs.webkit.org/show_bug.cgi?id=56263

Attachment 85699: Patch with fixes
https://bugs.webkit.org/attachment.cgi?id=85699&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85699&action=review

This patch seems like a hack.  We're randomly dropping something in the global
scope that extensions can key off of to trigger a quirk w.r.t. opener that's
we're probably going to remove anyway.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

This line will prevent this patch from landing.  Can we write a test for this
change?

> Source/WebCore/xml/XMLViewer.xsl:253
> -		       <span> <xsl:value-of
select="$xml_has_no_style_message"/> </span> 
> +		       <span> <xsl:value-of
select="$xml_has_no_style_message"/> </span>

This change seems unrelated.