[webkit-reviews] review granted: [Bug 54109] [Qt][WK2]Unbreak InjectedBundle on Qt : [Attachment 85598] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 54109: [Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109

Attachment 85598: Patch
https://bugs.webkit.org/attachment.cgi?id=85598&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85598&action=review

> Source/WebKit2/Shared/WebURL.h:72
> +	   if (!!m_parsedURL)

No need for the !! here.

> Source/WebKit2/Shared/WebURL.h:74
> +	   m_parsedURL.set(new WebCore::KURL(WebCore::KURL(), m_string));

Please use adoptPtr and assignment here instead of OwnPtr::set.

> Tools/WebKitTestRunner/StringFunctions.h:100
> +inline std::ostream& operator<<(std::ostream& out, const WKURLRef urlRef)

No need for the "const" here.