[webkit-reviews] review granted: [Bug 56213] Selection uses first mousemove's localRect instead of that of mousedown : [Attachment 85692] Fixed per Tony's comment

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 56213: Selection uses first mousemove's localRect instead of that of
mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213

Attachment 85692: Fixed per Tony's comment
https://bugs.webkit.org/attachment.cgi?id=85692&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85692&action=review

> LayoutTests/platform/mac/editing/selection/fake-drag-expected.txt:8
> +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV >
BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document
toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 4 of #text
> DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream
stillSelecting:FALSE
> +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 4 of #text > DIV >
BODY > HTML > #document to 4 of #text > DIV > BODY > HTML > #document
toDOMRange:range from 4 of #text > DIV > BODY > HTML > #document to 5 of #text
> DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream
stillSelecting:FALSE

Ah, it does fire selection changed twice.  That seems harmless . . .