[webkit-reviews] review granted: [Bug 56053] Deleting content directly following a button inserts an unnecessary placeholder : [Attachment 85253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 11:31:12 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 56053: Deleting content directly following a button inserts an unnecessary
placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053

Attachment 85253: Patch
https://bugs.webkit.org/attachment.cgi?id=85253&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85253&action=review

looks sane to me.

> LayoutTests/editing/deleting/delete-inserts-br-after-button.html:9
> +target = document.getElementById("container");

Nit: Missing "var".

> LayoutTests/editing/deleting/delete-inserts-br-after-button.html:11
> +window.getSelection().modify("move", "Right", "character");

Nit: Capitalize / de-capitalize all words here (make them consistent).


More information about the webkit-reviews mailing list