[webkit-reviews] review granted: [Bug 48799] Crash when dragging and dropping in a document with an invalid XHTML header : [Attachment 85652] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 48799: Crash when dragging and dropping in a document with an invalid XHTML
header
https://bugs.webkit.org/show_bug.cgi?id=48799

Attachment 85652: Patch
https://bugs.webkit.org/attachment.cgi?id=85652&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85652&action=review

> LayoutTests/editing/pasteboard/drop-file-svg.html:23
> +<p>PASS unless crash</p>

Nit: Please make this a full sentence.	Also, please mention that this test
requires DRT.

> Source/WebCore/page/DragController.cpp:398
> +    if (!m_page->dragCaretController()->isNone()) {
> +	   if (!dispatchTextInputEventFor(innerFrame, dragData))

Nit: Can we just combine these into 1 if statement using && ?