[webkit-reviews] review denied: [Bug 56296] Clean up includes/forward declarations in IconDatabaseBase : [Attachment 85686] Patch v2 - Left out the WebKit pieces

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 56296: Clean up includes/forward declarations in IconDatabaseBase
https://bugs.webkit.org/show_bug.cgi?id=56296

Attachment 85686: Patch v2 - Left out the WebKit pieces
https://bugs.webkit.org/attachment.cgi?id=85686&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85686&action=review

> Source/WebCore/loader/icon/IconDatabase.h:31
> +#include "PlatformString.h"

This should be <wtf/text/WTFString.h>

> Source/WebCore/loader/icon/IconDatabaseBase.h:34
> +namespace WTF {
> +class String;
> +}

This should use <wtf/Forward.h>

> Source/WebCore/loader/icon/IconDatabaseBase.h:97
> +    virtual WTF::String databasePath() const;

If you use forward.h, the WTF is not necessary.