[webkit-reviews] review canceled: [Bug 56310] Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js : [Attachment 85684] [PATCH] Test added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 10:04:39 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has canceled Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 56310: Web Inspector: Fix handling of the CSSAgent.setStyleSheetText()
results in CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=56310

Attachment 85684: [PATCH] Test added
https://bugs.webkit.org/attachment.cgi?id=85684&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85684&action=review

> LayoutTests/inspector/styles/styles-stylesheet-text.html:1
> +<html>

can be get-set-stylesheet-text.html

> LayoutTests/inspector/styles/styles-stylesheet-text.html:24
> +    function test_findStyleSheet(error, styleSheetIds)

use InspectorTest.runTestSuite for the reset instead.

Also, I think getAllStyles should be called getAllStyleSheets and return
stylesheet metainfo ('url' for now) along with its id.


More information about the webkit-reviews mailing list