[webkit-reviews] review granted: [Bug 56312] Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function : [Attachment 85679] changed test

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 56312: Web Inspector: Factor out binary search algo from the
insertionIndexForObjectInListSortedByFunction function
https://bugs.webkit.org/show_bug.cgi?id=56312

Attachment 85679: changed test
https://bugs.webkit.org/attachment.cgi?id=85679&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85679&action=review

> LayoutTests/inspector/utilities.html:8
> +    function BinaryIndexOfTest()

start with lowerCase.

> LayoutTests/inspector/utilities.html:19
> +	   function TestArray(array)

lowerCase.

> LayoutTests/inspector/utilities.html:21
> +	       function Comparator(a, b)

lowerCase

> LayoutTests/inspector/utilities.html:49
> +    BinaryIndexOfTest();

No need to declare and run - simply inline.