[webkit-reviews] review denied: [Bug 56312] Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function : [Attachment 85676] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 08:25:30 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 56312: Web Inspector: Factor out binary search algo from the
insertionIndexForObjectInListSortedByFunction function
https://bugs.webkit.org/show_bug.cgi?id=56312

Attachment 85676: patch
https://bugs.webkit.org/attachment.cgi?id=85676&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good except for the test. We don't use initialize_ prefix in the tests.


More information about the webkit-reviews mailing list