[webkit-reviews] review granted: [Bug 56145] [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback. : [Attachment 85673] V2 with comments taken into account.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 07:52:42 PDT 2011


Tor Arne Vestbø <vestbo at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 56145: [Qt] Seeking videos using the timeline bar does not work properly
and stop the video playback.
https://bugs.webkit.org/show_bug.cgi?id=56145

Attachment 85673: V2 with comments taken into account.
https://bugs.webkit.org/attachment.cgi?id=85673&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85673&action=review

r=me with comment

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:448
> +	   if (m_mediaPlayer->state() != QMediaPlayer::PlayingState) {

This needs to check the webcorePlayer state


More information about the webkit-reviews mailing list