[webkit-reviews] review denied: [Bug 32723] [Qt] QWebFrame::setUrl works only from second time if url fragment is present : [Attachment 85471] patch v2, all qt api tests pass now

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Caio Marcelo de Oliveira
Filho <caio.oliveira at openbossa.org>'s request for review:
Bug 32723: [Qt] QWebFrame::setUrl works only from second time if url fragment
is present
https://bugs.webkit.org/show_bug.cgi?id=32723

Attachment 85471: patch v2, all qt api tests pass now
https://bugs.webkit.org/attachment.cgi?id=85471&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
This looks good (I like the inline function to clarify what is going on there).
But I would like to see a bit more test coverage.

Like what is in the history, what if I call setUrl with an default constructed
QUrl(), what is the referer for the next request, etc.