[webkit-reviews] review granted: [Bug 56111] Web Inspector: Optimize backend-frontend data transfer volume for CSS styles : [Attachment 85350] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 56111: Web Inspector: Optimize backend-frontend data transfer volume for
CSS styles
https://bugs.webkit.org/show_bug.cgi?id=56111

Attachment 85350: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=85350&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85350&action=review

> LayoutTests/inspector/styles/styles-new-API.html:244
> +		   InspectorTest.addResult("['" + property.name + "':'" +
property.value + "'" + (property.priority === "important" ? " is-important" :
"") + ((typeof property.parsedOk === "undefined") ? "" : " non-parsed") +"] @["
+ property.startOffset + "-" + property.endOffset + "] " + (property.status ||
"style"));

("parsedOk" in property)

> Source/WebCore/inspector/InspectorStyleSheet.cpp:453
> +	   String status = it->disabled ? "disabled" : "active";

I'd suggest that:
- active properties have no additional flags,
- disabled properties have "disabled" set to true,
- style (longhand) properties are placed under source code (shorthand)
properties in case of regular styles + computed styles are returned as arrays
of longhands.