[webkit-reviews] review granted: [Bug 56270] The JIT 'friend's many classes in JSC; start unwinding this. : [Attachment 85621] The patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 56270: The JIT 'friend's many classes in JSC; start unwinding this.
https://bugs.webkit.org/show_bug.cgi?id=56270

Attachment 85621: The patch
https://bugs.webkit.org/attachment.cgi?id=85621&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85621&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:2550
>			};
>			buildConfigurationList = 149C277108902AFE008A9EFC /*
Build configuration list for PBXProject "JavaScriptCore" */;
>			compatibilityVersion = "Xcode 3.1";
> +			developmentRegion = English;
>			hasScannedForEncodings = 1;
>			knownRegions = (
>				English,

How old is your xcode?	Please don't check this in.

> Source/JavaScriptCore/interpreter/RegisterFile.h:138
> +	   Register*const* addressOfEnd() const

I think a space is needed somewhere here. How about Register* const *
addressOfEnd() const

> Source/JavaScriptCore/runtime/JSCell.h:144
> +	   Structure*const* addressOfStructure() const

Again with the no spaces!

> Source/JavaScriptCore/runtime/JSVariableObject.h:59
> +	   WriteBarrier<Unknown>*const* addressOfRegisters() const { return
&m_registers; }

And here.