[webkit-reviews] review requested: [Bug 52934] Use WTF::StringHasher in WebCore : [Attachment 85616] IntegerArray fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 13 03:52:15 PDT 2011


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 52934: Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

Attachment 85616: IntegerArray fix
https://bugs.webkit.org/attachment.cgi?id=85616&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #14)
> The IntegerArrayHash::hash change here was wrong; passing the wrong length.
Not sure how I missed it when reviewing!
The IntegerArray::size returns the count of integers and not the memory size in
bytes, so the hashing was wrong all the time.

BTW: Can you review the follow up patch at bug 53532?


More information about the webkit-reviews mailing list