[webkit-reviews] review granted: [Bug 56193] Dragging image to desktop gives webloc instead of image file in WebKit2 : [Attachment 85589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 12 11:03:12 PST 2011


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 56193: Dragging image to desktop gives webloc instead of image file in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193

Attachment 85589: Patch
https://bugs.webkit.org/attachment.cgi?id=85589&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85589&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1519
> +#if PLATFORM(MAC)
> +    platformDragEnded();
> +#endif

In general, I like having calls like these without the #if, and have each
platform just have a stubbed out implementation.


More information about the webkit-reviews mailing list