[webkit-reviews] review granted: [Bug 56210] WebKit2: Implement a full screen window controller : [Attachment 85518] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 56210: WebKit2: Implement a full screen window controller
https://bugs.webkit.org/show_bug.cgi?id=56210

Attachment 85518: Patch
https://bugs.webkit.org/attachment.cgi?id=85518&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85518&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:361
> +- (void)getFullScreenRect:(WebCore::IntRect*)rect

This can just return an IntRect object.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:368
> +    rect->setX(roundl(NSMinX(windowFrame)));
> +    rect->setY(roundl(NSMinY(windowFrame)));
> +    rect->setWidth(roundl(NSWidth(windowFrame)));
> +    rect->setHeight(roundl(NSHeight(windowFrame)));

Instead of doing this, you can just use enclosingIntRect([[self window]
frame]);

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:477
> +	   return NULL;

This should be return 0;

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:507
> +    return (WKFullScreenWindow *)[self window];

Please add a

ASSERT([[self window] isKindOfClass:[WKFullScreenWindow class]])

before casting.