[webkit-reviews] review granted: [Bug 55993] WebKit2: Plumb new full screen animation APIs through WebKit2. : [Attachment 85504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 11 16:55:48 PST 2011


Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 55993: WebKit2: Plumb new full screen animation APIs through WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=55993

Attachment 85504: Patch
https://bugs.webkit.org/attachment.cgi?id=85504&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85504&action=review

> Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:69
> +   
m_page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(),
supports, 0, CoreIPC::Connection::NoTimeout);

No need to pass NoTimeout to sendSync, that's the default argument.


More information about the webkit-reviews mailing list