[webkit-reviews] review denied: [Bug 56214] Ensure all values are correctly tagged in the registerfile : [Attachment 85520] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 56214: Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214

Attachment 85520: Patch
https://bugs.webkit.org/attachment.cgi?id=85520&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj change should
probably be reverted?

> *this = JSValue(reinterpret_cast<JSCell*>(activation));

These casts are all incorrect, they should be static_casts (reinterpret_cast is
almost always the wrong cast when casting within a class hierarchy).
But can't you just delete all these overloaded= operators? - why doesn't the
compiler just call the operator=(JSValue) automatically?

If we're going to access the two halves of the value like we do in JSVALUE32_64
it seems like we should have the IntValueDescriptor defined in JSValue, where
it is for JSVALUE32_64 (better still, unify the two!)

r- for the reinterpreting.