[webkit-reviews] review granted: [Bug 56217] Start using derived sources correctly and link minidom with JavaScriptCore gyp project. : [Attachment 85517] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 56217: Start using derived sources correctly and link minidom with
JavaScriptCore gyp project.
https://bugs.webkit.org/show_bug.cgi?id=56217

Attachment 85517: Patch
https://bugs.webkit.org/attachment.cgi?id=85517&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85517&action=review

This restructures how the build works a bit, but probably in a good direction.

> Source/JavaScriptCore/gyp/generate-dtrace-header.sh:3
> +TRACING_D="${SRCROOT}/../runtime/Tracing.d";

The ... here makes me a bit sad, but it's probably ok.	Having these paths
based on DEPTH is better.  Maybe we should pass the directory in like we're
doing for the intermediate dir.