[webkit-reviews] review granted: [Bug 56216] Rework IconDatabase disabling while allowing for a "pluggable" icon database : [Attachment 85514] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 11 13:10:05 PST 2011


Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 56216: Rework IconDatabase disabling while allowing for a "pluggable" icon
database
https://bugs.webkit.org/show_bug.cgi?id=56216

Attachment 85514: Patch v1
https://bugs.webkit.org/attachment.cgi?id=85514&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85514&action=review

> Source/WebCore/loader/icon/IconDatabaseBase.cpp:58
> +} //namespace WebCore

Missing space.

> Source/WebCore/loader/icon/IconDatabaseBase.h:87
> +}; // class IconDatabaseBase

We don't put these // class comments usually.


More information about the webkit-reviews mailing list