[webkit-reviews] review granted: [Bug 47159] CSS 2.1 failure: background-position-201, background-position-202 : [Attachment 85503] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 11 11:45:50 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 47159: CSS 2.1 failure: background-position-201, background-position-202
https://bugs.webkit.org/show_bug.cgi?id=47159

Attachment 85503: Patch
https://bugs.webkit.org/attachment.cgi?id=85503&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85503&action=review

> Source/WebCore/css/CSSParser.h:93
> +	   enum FillPositionFlag { InvalidFillPosition = 0,
AmbiguousFillPosition = 1, XFillPosition = 2, YFillPosition = 4 };

If this is a bitmask I'd prefer to see 0, 1 << 0, 1 << 1, 1 << 2


More information about the webkit-reviews mailing list