[webkit-reviews] review denied: [Bug 56205] m_restrictions needs to allow multiple values (a bitfield) : [Attachment 85492] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 56205: m_restrictions needs to allow multiple values (a bitfield)
https://bugs.webkit.org/show_bug.cgi?id=56205

Attachment 85492: Patch
https://bugs.webkit.org/attachment.cgi?id=85492&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85492&action=review

> Source/WebCore/ChangeLog:9
> +	   https://bugs.webkit.org/show_bug.cgi?id=56205
> +	   m_restrictions needs to allow multiple values (a bitfield)
> +
> +	   Make the m_restrictions ivar of unsigned type, so that it
> +	   can hold multiple values of BehaviorRestrictions.

Somewhere in this text you should mention media elements.

> Source/WebCore/html/HTMLMediaElement.h:363
> -    BehaviorRestrictions m_restrictions;
> +    unsigned m_restrictions;

I think you should add a typedef for BehaviorRestrictions, and rename the enum
to BehaviorRestrictionFlags