[webkit-reviews] review requested: [Bug 56067] Overlay scrollers in overflow areas need send notifications at appropriate times (showing up, resizing) : [Attachment 85488] Better Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 56067: Overlay scrollers in overflow areas need send notifications at
appropriate times (showing up, resizing)
https://bugs.webkit.org/show_bug.cgi?id=56067

Attachment 85488: Better Patch
https://bugs.webkit.org/attachment.cgi?id=85488&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Sorry about the crashes. The crashes happen on MacOS X too, and I was able to
find a reproducible case. I discovered that when we crashed, the ScrollableArea
was garbage. The problem is that we added the ScrollableArea, and were not able
to remove it because when the ScrollableArea was destroyed, we no longer had a
reference to the Page. Here is a new patch that adds a member variable to the
relevant ScrollableArea classes to keep a weak pointer to Page so that they
don't have to rely on Frames and/or Renderers having Pages still. This patch
fixes the reproducible case that I found. 

However, I do not have time to give this patch the testing that it needs today,
so I do not intend to check it in until I live on it more. I will update the
bug once I have done that.

In the meantime, if anyone has comments on the approach or the patch in
general, please comment :-)