[webkit-reviews] review denied: [Bug 45882] WebCore..Frame..domWindow ReadAV at NULL (f8cd71f24fff11a7dbb6a39e738fe929) : [Attachment 85175] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 11 09:42:32 PST 2011
Adam Barth <abarth at webkit.org> has denied Berend-Jan Wever
<skylined at chromium.org>'s request for review:
Bug 45882: WebCore..Frame..domWindow ReadAV at NULL
(f8cd71f24fff11a7dbb6a39e738fe929)
https://bugs.webkit.org/show_bug.cgi?id=45882
Attachment 85175: Patch
https://bugs.webkit.org/attachment.cgi?id=85175&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
All patches need a ChangeLog. Please see
http://www.webkit.org/coding/contributing.html for instructions about preparing
patches.
I'm not sure this change is correct. The correct fix is to using the following
idiom:
V8BindingState* state = V8BindingState::Only();
DOMWindow* activeWindow = state->activeWindow();
More information about the webkit-reviews
mailing list