[webkit-reviews] review denied: [Bug 16708] CSS: Slow parsing of rgb() with percent values : [Attachment 85468] proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Andras Becsi <abecsi at webkit.org>'s
request for review:
Bug 16708: CSS: Slow parsing of rgb() with percent values
https://bugs.webkit.org/show_bug.cgi?id=16708

Attachment 85468: proposed patch
https://bugs.webkit.org/attachment.cgi?id=85468&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Quoth CSS ( http://www.w3.org/TR/css3-color/#rgb-def ):

"The format of an RGB value in the functional notation is ‘rgb(’ followed by a
comma-separated list of three numerical values (either three integer values or
three percentage values) followed by ‘)’." (And the same is basically repeated
for rgba().)

Thus we should not allow mixing integer and percentage component values, i.e it
should be either all integers, or all percentages.

The in-tree test css2.1/t040306-syntax-01-f.html covers mixing of RGB component
types, and should fail with this change.