[webkit-reviews] review requested: [Bug 56100] Web Inspector: introduce error argument for backend callbacks : [Attachment 85460] [patch] second version
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 11 04:43:29 PST 2011
Ilya Tikhonovsky <loislo at chromium.org> has asked for review:
Bug 56100: Web Inspector: introduce error argument for backend callbacks
https://bugs.webkit.org/show_bug.cgi?id=56100
Attachment 85460: [patch] second version
https://bugs.webkit.org/attachment.cgi?id=85460&action=review
------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
1) response message field 'errors' was renamed to 'protocolErrors';
2) new field 'error' was introduced for the response messages. It is used for
transfer custom error's text from the backend agents' functions to frontend
callbacks;
3) 'seq' field in the request messages was renamed to 'id';
4) 'seq' field in the response messages was renamed to 'requestId';
there is no tests for custom-error functionality.
I'll do that in the next patch.
More information about the webkit-reviews
mailing list