[webkit-reviews] review requested: [Bug 54151] Implement an API to play/pause/scrub animations : [Attachment 85459] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 11 04:41:26 PST 2011
Dean Jackson <dino at apple.com> has asked for review:
Bug 54151: Implement an API to play/pause/scrub animations
https://bugs.webkit.org/show_bug.cgi?id=54151
Attachment 85459: Updated patch
https://bugs.webkit.org/attachment.cgi?id=85459&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
No review needed.
- It turns out the style error that I thought was a mistake was telling me I'd
made a typo (Webkit -> WebKit) in the v8 bindings :)
- Use numeric_limit<> rather than INFINITY
- Make sure the animations are ordered as they are returned (test was
occasionally failing)
- Test also checks for null now.
More information about the webkit-reviews
mailing list