[webkit-reviews] review granted: [Bug 56158] support encoding /decoding WebData in usermessages : [Attachment 85425] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 10 21:34:53 PST 2011
Sam Weinig <sam at webkit.org> has granted Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 56158: support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158
Attachment 85425: patch
https://bugs.webkit.org/attachment.cgi?id=85425&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85425&action=review
> Source/WebKit2/Shared/UserMessageCoders.h:305
> + coder.m_root = WebData::create(buffer);
> + break;
> + }
I think this should return true, hm, we are inconsistent here. I should fix
that, the break is fine I guess.
More information about the webkit-reviews
mailing list