[webkit-reviews] review denied: [Bug 56027] Assert that editing does not ignore position's anchorNode if position is an offset in anchor : [Attachment 85422] patch for review

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 56027: Assert that editing does not ignore position's anchorNode if
position is an offset in anchor
https://bugs.webkit.org/show_bug.cgi?id=56027

Attachment 85422: patch for review
https://bugs.webkit.org/attachment.cgi?id=85422&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85422&action=review

Behavior changes need tests.

> Source/WebCore/dom/PositionIterator.cpp:43
> +	   if
(editingIgnoresContent(m_nodeAfterPositionInAnchor->parentNode()))
> +	       return positionBeforeNode(m_anchorNode);

How does this change behavior?	How do we test this?

> Source/WebCore/editing/ApplyStyleCommand.cpp:1699
> +	   positionForStyleComparison =
firstPositionInOrBeforeNode(startNode.get());

Same question.

> Source/WebCore/editing/htmlediting.cpp:-79
> -	      !node->hasTagName(buttonTag) &&

Same question. :)  Buttons are editing boundaries, aren't they?  And aren't
their editable kids shadow DOMs?

> Source/WebCore/editing/visible_units.cpp:381
> +    VisiblePosition visPos = startNode->isTextNode() ?
VisiblePosition(Position(startNode, static_cast<InlineTextBox
*>(startBox)->start(), Position::PositionIsOffsetInAnchor), DOWNSTREAM)

Same qeustion. :)