[webkit-reviews] review denied: [Bug 51878] Add WebKit1 API to view and delete local storage : [Attachment 85409] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Anton D'Auria <adauria at apple.com>'s
request for review:
Bug 51878: Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

Attachment 85409: Patch
https://bugs.webkit.org/attachment.cgi?id=85409&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85409&action=review

Looks good, but the build breaks and the m_isActive guard I pointed out need to
be fixed.

> Source/WebCore/storage/StorageAreaSync.cpp:459
>      if (!count) {
>	   query.finalize();
>	   m_database.close();
> -	   String databaseFilename =
m_syncManager->fullDatabaseFilename(m_databaseIdentifier);
> -	   if (!SQLiteFileSystem::deleteDatabaseFile(databaseFilename))
> -	       LOG_ERROR("Failed to delete database file %s\n",
databaseFilename.utf8().data());
> +	   StorageTracker::tracker().deleteOrigin(m_databaseIdentifier);

Should guard this with the m_isActive flag, also.

> Source/WebKit/ChangeLog:18
> +2011-03-10  Anton D'Auria  <adauria at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add WebKit1 API to view and delete local storage
> +	   https://bugs.webkit.org/show_bug.cgi?id=51878
> +
> +	   * WebKit.xcodeproj/project.pbxproj:
> +
> +2011-03-02  Anton D'Auria  <adauria at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=51878
> +	   Add WebKit1 API to view and delete local storage
> +
> +	   * WebKit.xcodeproj/project.pbxproj:
> +

Double ChangeLog entry