[webkit-reviews] review denied: [Bug 56148] [chromium] Graphics Context is not properly recovered if the GPU process dies. : [Attachment 85397] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 56148: [chromium] Graphics Context is not properly recovered if the GPU
process dies.
https://bugs.webkit.org/show_bug.cgi?id=56148

Attachment 85397: Patch
https://bugs.webkit.org/attachment.cgi?id=85397&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85397&action=review

Good work fixing these deep issues; r- for a couple of relatively minor
concerns.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:90
> +    PassRefPtr<LayerChromium> rootLayer() { return m_rootLayer.release(); }

I've already given you this feedback offline, but in this form this method
should be named something like "releaseRootLayer".

> Source/WebKit/chromium/src/WebViewImpl.cpp:2436
> +	       getCompositorContextAttributes(), m_page->chrome(),
GraphicsContext3D::RenderDirectlyToHostWindow);

Are any similar improvements needed in WebGLRenderingContext or WebGLLayer?

> Source/WebKit/chromium/src/WebViewImpl.cpp:2443
> +	   // TODO(amarinichev): In MacOS newContext->reshape method needs to
be

WebKit uses FIXME without an owner, not TODO.