[webkit-reviews] review denied: [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1 : [Attachment 85403] Fixed according to recent NetscapePluginQt/Gtk -> NetscapePluginX11 changes

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Oleg Romashin (:romaxa)
<romaxa at gmail.com>'s request for review:
Bug 55719: [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719

Attachment 85403: Fixed according to recent NetscapePluginQt/Gtk ->
NetscapePluginX11 changes
https://bugs.webkit.org/attachment.cgi?id=85403&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85403&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:280
> +void
> +QWKPagePrivate::setComplexTextInputEnabled(uint64_t
pluginComplexTextInputIdentifier,
> +					      bool complexTextInputEnabled)

Coding style, this should all be on one line.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:140
> -	   // FIXME: This is Mac specific.
> +#if PLATFORM(MAC)
>	   reply->encode(CoreIPC::MachPort(0, MACH_MSG_TYPE_MOVE_SEND));
> +#else
> +	   ASSERT_NOT_REACHED();
> +#endif
>	   replyWebProcessProxy->connection()->sendSyncReply(reply);

Why the ASSERT_NOT_REACHED()? It reads to me like we can indeed reach this
code.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:217
> +

Unnecessary newline.

> Source/WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:74
> +    connectionIdentifier = 0;
> +    ASSERT(connectionIdentifier);

What's going on here?