[webkit-reviews] review requested: [Bug 56145] [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback. : [Attachment 85390] Patch to fix the issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 14:29:04 PST 2011


Alexis Menard <alexis.menard at openbossa.org> has asked  for review:
Bug 56145: [Qt] Seeking videos using the timeline bar does not work properly
and stop the video playback.
https://bugs.webkit.org/show_bug.cgi?id=56145

Attachment 85390: Patch to fix the issue
https://bugs.webkit.org/attachment.cgi?id=85390&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on
QMediaPlayer is good enough. positionChanged() will be emitted when the data is
buffered. On Linux the signal was not emitted because of a bug in QtMultimedia.
Also we need to resume the playback after receiving positionChanged() because
beginScrubbing() actually paused the mediaplayer previously.

A patch has been send to the Qt Multimedia team for review.


More information about the webkit-reviews mailing list