[webkit-reviews] review granted: [Bug 56117] [v8] Change the way group id for CSS objects is calculated : [Attachment 85346] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 13:57:14 PST 2011


Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 56117: [v8] Change the way group id for CSS objects is calculated
https://bugs.webkit.org/show_bug.cgi?id=56117

Attachment 85346: Patch
https://bugs.webkit.org/attachment.cgi?id=85346&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  It's too bad it's hard to test for the absence of these memory leaks. 
This code is complex and subtle.  I don't fully understand the traversal you're
doing here.  It seems to rely on the details of the CSS object model, which I
don't know how stable they are.  I'm marking this r+ for now, but that's mostly
because I don't know who else would be better to review it...


More information about the webkit-reviews mailing list