[webkit-reviews] review granted: [Bug 55581] Test results don't get uploaded if test-result-archive fails to delete the results directory : [Attachment 85375] Ignore errors from files being held open when creating a test result archive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 12:47:37 PST 2011


Mark Rowe (bdash) <mrowe at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 55581: Test results don't get uploaded if test-result-archive fails to
delete the results directory
https://bugs.webkit.org/show_bug.cgi?id=55581

Attachment 85375: Ignore errors from files being held open when creating a test
result archive
https://bugs.webkit.org/attachment.cgi?id=85375&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me.  It would be nice if we could somehow detect the stale files and clean
them up (move them to a different directory perhaps?), but this is certainly a
big improvement.


More information about the webkit-reviews mailing list