[webkit-reviews] review requested: [Bug 56132] [Gtk] Add support for userscripts tests : [Attachment 85373] Add support for testing user script tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 12:37:58 PST 2011


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 56132: [Gtk] Add support for userscripts tests
https://bugs.webkit.org/show_bug.cgi?id=56132

Attachment 85373: Add support for testing user script tests
https://bugs.webkit.org/attachment.cgi?id=85373&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This patch adds support for testing user script tests by adding methods for
adding a user script to a page group and removing all the content from a page
group to the DumpRenderTreeSupport class. These two methods are then used in
DumpRenderTree tool for testing these tests.

This patch also resets defaults to consistent values right after the test has
finished, before loading about:blank. Without resetting these values a failure
occurs when running tests in userscripts directory. We should rethink if
loading about:blank after every test is actually needed and whether there's a
better way of gaining benefits that loading about:blank brings.


More information about the webkit-reviews mailing list