[webkit-reviews] review granted: [Bug 55764] Web Inspector: resource load cancellation is reported to console as an error : [Attachment 85318] patch (fixed binary diff)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 10 12:34:41 PST 2011
Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 55764: Web Inspector: resource load cancellation is reported to console as
an error
https://bugs.webkit.org/show_bug.cgi?id=55764
Attachment 85318: patch (fixed binary diff)
https://bugs.webkit.org/attachment.cgi?id=85318&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85318&action=review
Please address my comment prior to landing.
> Source/WebCore/inspector/front-end/ConsoleView.js:726
> + else if (resource.statusCode)
You should make sure InspectorInstrumentation marks resources as failed prior
to reporting error to the console. Then you can revert this change.
More information about the webkit-reviews
mailing list