[webkit-reviews] review granted: [Bug 55919] Yet another multi-threading bug in WebSQLDatabase. : [Attachment 85280] wrapper

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 11:42:40 PST 2011


David Levin <levin at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 55919: Yet another multi-threading bug in WebSQLDatabase.
https://bugs.webkit.org/show_bug.cgi?id=55919

Attachment 85280: wrapper
https://bugs.webkit.org/attachment.cgi?id=85280&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85280&action=review

Two nits. If you fixed them before check in, that would be nice, but the check
in could go in as is.

> Source/WebCore/ChangeLog:7
> +	   which holds those referenc whose dtor will schedule the release of
those references on the ScriptExecution thread.

typo: referenc

> Source/WebCore/storage/SQLCallbackWrapper.h:75
> +	       callback =  m_callback.release().leakRef();

extra space after =


More information about the webkit-reviews mailing list