[webkit-reviews] review denied: [Bug 55834] fast/forms/onchange-setvalueforuser.html failing on Windows 7 and Windows XP since r80412 : [Attachment 85122] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 10 08:56:04 PST 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 55834: fast/forms/onchange-setvalueforuser.html failing on Windows 7 and
Windows XP since r80412
https://bugs.webkit.org/show_bug.cgi?id=55834

Attachment 85122: Patch
https://bugs.webkit.org/attachment.cgi?id=85122&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
I think checking in expected failure results is in fact the right thing to do.
In general our rule is: if the test is failing the same way every time, and
isn't crashing or timing out, we should check in expected failure results. See
http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10017 for some
discussion of this policy.


More information about the webkit-reviews mailing list