[webkit-reviews] review granted: [Bug 55226] Add appropriate UA string tags for running on Windows x64 : [Attachment 85284] Patch v2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 55226: Add appropriate UA string tags for running on Windows x64
https://bugs.webkit.org/show_bug.cgi?id=55226

Attachment 85284: Patch v2
https://bugs.webkit.org/attachment.cgi?id=85284&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85284&action=review

Looks sane to me!

> Source/WebCore/platform/win/SystemInfo.cpp:122
> +    if (!initialized) {
> +	   initialized = true;

Can't we exit early here instead? as in
if (initialized)
    return wow64;
But not strongly opinionated.

> Source/WebCore/platform/win/SystemInfo.cpp:130
> +	       wow64 = ((*isWOW64Process)(GetCurrentProcess(), &result) &&
result);

I'd prefer isWOW64Process(GetCurrentProcess(), &result) && result; but there
doesn't seem to be an explicit rule stated anywhere.