[webkit-reviews] review granted: [Bug 55979] Unify Windows version checks : [Attachment 85277] Part 2, v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 19:23:01 PST 2011


Mihai Parparita <mihaip at chromium.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 55979: Unify Windows version checks
https://bugs.webkit.org/show_bug.cgi?id=55979

Attachment 85277: Part 2, v5
https://bugs.webkit.org/attachment.cgi?id=85277&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85277&action=review

> Source/WebCore/platform/win/SystemInfo.cpp:37
> +    static WindowsVersion version;

It might be safer to have a WindowsUnknown default value here, but I don't have
a strong opinion about that.


More information about the webkit-reviews mailing list