[webkit-reviews] review requested: [Bug 55979] Unify Windows version checks : [Attachment 85247] Part 2, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 15:42:13 PST 2011


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 55979: Unify Windows version checks
https://bugs.webkit.org/show_bug.cgi?id=55979

Attachment 85247: Part 2, v1
https://bugs.webkit.org/attachment.cgi?id=85247&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
By unifying the places that construct the UA string to call my new function,
the fix for bug 55226 will become very simple.	Unfortunately, I am skeptical
that the Qt part will work, and even if it does, I couldn't find enough docs on
GetVersionEx() on WinCE to fully replace the old code.	Oh well; if it doesn't
work, I can yank it.


More information about the webkit-reviews mailing list