[webkit-reviews] review denied: [Bug 55989] [GTK] Possible leaks after splitting TextCheckerClientEnchant. : [Attachment 85132] simplechanges

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 55989: [GTK] Possible leaks after splitting TextCheckerClientEnchant.
https://bugs.webkit.org/show_bug.cgi?id=55989

Attachment 85132: simplechanges
https://bugs.webkit.org/attachment.cgi?id=85132&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85132&action=review

Thanks for continuing to clean this code up! I really appreciate it. I've one
suggested change.

> Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:113
> +		   g_utf8_strncpy(word.get(), cstart, end - start);

We've already calculated the final offset here, why not do this:

CString word(cstart, bytes);
int result = enchant_dict_check(dict, word.data(), -1);