[webkit-reviews] review canceled: [Bug 56004] REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document : [Attachment 85201] fixes the crash

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled  review:
Bug 56004: REGRESSION: crash in nextLinePosition when extending selection
forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004

Attachment 85201: fixes the crash
https://bugs.webkit.org/attachment.cgi?id=85201&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 85201 [details] [details])
> > OK.  Should we do previousLinePosition too?
> 
> I can't reproduce the crash when I do backwards but you're right that we
should probably fix there as well.  Should we include in this patch without a
test?

I think we should given the symmetry of these two functions.