[webkit-reviews] review granted: [Bug 56026] Make sure orientation is included in all places in FontPlatformDataLinux : [Attachment 85194] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 56026: Make sure orientation is included in all places in
FontPlatformDataLinux
https://bugs.webkit.org/show_bug.cgi?id=56026

Attachment 85194: Patch
https://bugs.webkit.org/attachment.cgi?id=85194&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85194&action=review

>>> Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h:95
>>> +	 FontPlatformData(SkTypeface*, const char* name, float textSize, bool
fakeBold, bool fakeItalic, FontOrientation orientation = Horizontal,
TextOrientation textOrientation = TextOrientationVerticalRight);
>> 
>> The parameter name "orientation" adds no information, so it should be
removed.  [readability/parameter_name] [5]
> 
> The parameter name "textOrientation" adds no information, so it should be
removed.  [readability/parameter_name] [5]

I agree with the style bot!