[webkit-reviews] review requested: [Bug 56017] REGRESSION:Soft hyphen is not always rendered : [Attachment 85182] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 09:19:07 PST 2011


David Sosby <dsosby at rim.com> has asked	for review:
Bug 56017: REGRESSION:Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Attachment 85182: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=85182&action=review

------- Additional Comments from David Sosby <dsosby at rim.com>
This is a proposed fix that resolves the issue seen in the demo file. 

The soft hyphen check was only being done inside of the while loop when a word
break or space was encountered. With some lines, there are no other word breaks
after the soft hyphen. The fix was to add a soft hyphen check after the loop
next to the platform hyphenation check (tryHyphenating).


More information about the webkit-reviews mailing list