[webkit-reviews] review denied: [Bug 55941] REGRESSION (r80478): broke GTK inspector tests : [Attachment 85069] proposed patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 55941: REGRESSION (r80478): broke GTK inspector tests
https://bugs.webkit.org/show_bug.cgi?id=55941

Attachment 85069: proposed patch
https://bugs.webkit.org/attachment.cgi?id=85069&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85069&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:-478
> -    setJavaScriptPaused(page->group(), true);

setJavaScriptPaused was also pausing PluginViews.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:488
> +    }

PageGroupLoadDeferrer is going to restore the list of deferred frames
(m_deferredFrames). Some of them might be dead by now since we are dispatching
event loop while on a breakpoint and allow various page interactions by means
of console.