[webkit-reviews] review granted: [Bug 52535] offsetLeft is wrong for elements inside a TD whose style is set to position:relative : [Attachment 85163] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 52535: offsetLeft is wrong for elements inside a TD whose style is set to
position:relative
https://bugs.webkit.org/show_bug.cgi?id=52535

Attachment 85163: Patch
https://bugs.webkit.org/attachment.cgi?id=85163&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85163&action=review

> Source/WebCore/ChangeLog:1
> +2011-03-09  Jeremy  <playmobil at dhcp-172-28-32-85.tlv.corp.google.com>

Double change log.

> Source/WebCore/ChangeLog:34
> +2011-03-07  Jeremy Moskovich  <jeremy at chromium.org>

Double change log.

> Source/WebCore/rendering/RenderObject.cpp:2155
> +bool RenderObject::isOriginallyRelPositioned() const

I would call this wasOriginallyRelativePositioned. No need to abbreviate, and
the verb tense of "is" and "originally" don’t match.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:112
> +    // WebKit overwrites the position:relative style for certain elements
for which such positioning is illegal or behavior is undefined.
> +    // This flag preserves the fact that the position attribute was
originally specified as relative.

Don}t need this comment twice. I would suggest keeping it just in
RenderObject.h.