[webkit-reviews] review denied: [Bug 55775] Web Inspector: introduce RuntimeAgent::evaluateAsJSON, implement completion, audits and image hover on its basis. : [Attachment 85144] [patch] second version. with test.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 55775: Web Inspector: introduce RuntimeAgent::evaluateAsJSON, implement
completion, audits and image hover on its basis.
https://bugs.webkit.org/show_bug.cgi?id=55775

Attachment 85144: [patch] second version. with test.
https://bugs.webkit.org/attachment.cgi?id=85144&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85144&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:253
> +	   // FIXME: validate JSON-stringifiable structure.

If returned structure has cycles it will crash the browser. We should add some
check here or use custom jsonificator here. Another option is to use hard-coded
limit on the structure nesting level. Something like 10-20 levels should work
fine for us. Please fix this.