[webkit-reviews] review granted: [Bug 55765] JavaMethod should not expose JavaString in its API : [Attachment 85044] Patch 1

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 55765: JavaMethod should not expose JavaString in its API
https://bugs.webkit.org/show_bug.cgi?id=55765

Attachment 85044: Patch 1
https://bugs.webkit.org/attachment.cgi?id=85044&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85044&action=review

rubber stamp = me assuming andrei LGTMs it

>>> Source/WebCore/bridge/jni/JavaMethod.h:48
>>> +	 virtual const char* signature() const= 0;
>> 
>> name() used to return const JavaString& but this had to be changed to avoid
JNI types in the API. String seems to be the obvious choice instead. I left
signature() returning const char* because I wanted to make as few changes as
possible. Note that returnType() also returns const char*.
>> 
>> If you think all three should use String, I'm happy to make the change but
would rather do so in a separate patch to keep this one as simple as possible.
> 
> Fine with doing in a subsequent CL, just wanted to understand why the
difference.

Space before =

> Source/WebCore/bridge/jni/JavaMethod.h:49
> +    virtual JNIType JNIReturnType() const= 0;

Space before =